chore: upgrade go-jose to v4 and update JWT serialization methods#2460
Open
chimanjain wants to merge 1 commit into
Open
chore: upgrade go-jose to v4 and update JWT serialization methods#2460chimanjain wants to merge 1 commit into
chimanjain wants to merge 1 commit into
Conversation
4f8fd75 to
ff6fcbf
Compare
Collaborator
|
This is a change that will take more effort on account of v4 enforcing a minimum key length. That means that if anyone has short keys configured in their environments in the wild auth will potentially fail: {"level":"ERROR","source":"main.main.func3","time":"2026-05-18T10:05:15.476020329-07:00","msg":"error exit","reason":"go-jose/go-jose: invalid key size for algorithm"}Potential additions:
|
Contributor
Author
Thanks @crozzy . I'll add additional checks and update UT's. Please review once I commit them |
f40d5ab to
380b25b
Compare
Signed-off-by: Chiman Jain <[email protected]>
74ad362 to
cc9dd2b
Compare
Contributor
Author
|
@crozzy can you please re review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: upgrade go-jose from
v3tov4and update JWT serialization methods